Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common static server address : Fix #424 #425

Merged
merged 6 commits into from
Aug 31, 2023
Merged

Common static server address : Fix #424 #425

merged 6 commits into from
Aug 31, 2023

Conversation

nabilatrhea
Copy link
Contributor

@nabilatrhea nabilatrhea commented Aug 31, 2023 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #424

Add the possibility to connect to the server using configuration file.

@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 83.87% and project coverage change: -0.02% ⚠️

Comparison is base (8547461) 78.57% compared to head (cb93a79) 78.56%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #425      +/-   ##
===============================================
- Coverage        78.57%   78.56%   -0.02%     
===============================================
  Files              309      310       +1     
  Lines             6918     6974      +56     
  Branches           704      712       +8     
===============================================
+ Hits              5436     5479      +43     
- Misses            1269     1281      +12     
- Partials           213      214       +1
Files Changed Coverage Δ
COMET.Web.Common/Components/Login.razor.cs 100.00% <ø> (ø)
...mon/Extensions/WebAssemblyHostBuilderExtensions.cs 0.00% <0.00%> (ø)
...Web.Common/Extensions/WebAssemblyHostExtensions.cs 0.00% <0.00%> (ø)
COMET.Web.Common/Model/DTO/AuthenticationDto.cs 100.00% <ø> (ø)
...ServerConnectionService/ServerConnectionService.cs 80.55% <80.55%> (ø)
...onents/SingleIterationApplicationTemplate.razor.cs 98.36% <97.43%> (+0.11%) ⬆️
COMET.Web.Common/Components/Login.razor 100.00% <100.00%> (ø)
COMET.Web.Common/Model/GlobalOptions.cs 100.00% <100.00%> (ø)
...Web.Common/ViewModels/Components/LoginViewModel.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

antoineatstariongroup
antoineatstariongroup requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@antoineatstariongroup antoineatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify your indentation setting inside VS and ReSharper. Moreover, don't use the server address inside the url if defined inside the configuration file

COMET.Web.Common.Tests/Components/IndexComponentTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common.Tests/Components/LoginTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common.Tests/Components/SingleIterationApplicationTemplateTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common.Tests/Services/ServerConnectionService/ServerConnectionServiceTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common/Components/Login.razor Outdated Show resolved Hide resolved
COMET.Web.Common/wwwroot/server_configuration.json Outdated Show resolved Hide resolved
COMETwebapp.Tests/Pages/ModelDashboard/ModelDashboardTestFixture.cs Outdated Show resolved Hide resolved
COMETwebapp.Tests/Pages/ParameterEditor/ParameterEditorTestFixture.cs Outdated Show resolved Hide resolved
COMETwebapp.Tests/Pages/Viewer/ViewerTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common/Services/ServerConnectionService/ServerConnectionService.cs Outdated Show resolved Hide resolved
antoineatstariongroup
antoineatstariongroup requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@antoineatstariongroup antoineatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some indentation problem

COMET.Web.Common.Tests/Components/SingleIterationApplicationTemplateTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common.Tests/Services/ServerConnectionService/ServerConnectionServiceTestFixture.cs Outdated Show resolved Hide resolved
COMET.Web.Common/Services/ServerConnectionService/ServerConnectionService.cs Outdated Show resolved Hide resolved
COMET.Web.Common/ViewModels/Components/LoginViewModel.cs Outdated Show resolved Hide resolved
COMET.Web.Common/Components/SingleIterationApplicationTemplate.razor.cs Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.9% 77.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@nabilatrhea nabilatrhea merged commit 536f637 into development Aug 31, 2023
8 of 9 checks passed
@nabilatrhea nabilatrhea deleted the feat/GH424-common-static-server-address branch August 31, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineatstariongroup antoineatstariongroup antoineatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

@jaimeatstariongroup jaimeatstariongroup Awaiting requested review from jaimeatstariongroup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Common] Add the possibility to have a static server address
3 participants
@nabilatrhea @samatstariongroup @antoineatstariongroup